Data injection stability improvements #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YrrepNoj
reviewed
Jul 26, 2022
YrrepNoj
previously approved these changes
Jul 27, 2022
Racer159
requested changes
Jul 27, 2022
Racer159
approved these changes
Jul 27, 2022
YrrepNoj
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Because @jeff-mccoy doesn't believe that I approve of his changes 👀
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
BREAKING: Removes the ability to specify data injections into generic pods vs pod + container Adds a compress flag for data injections to enable gzip compression on transfer Adds file copy activity logging while running the data injection Adds new Helm Chart config option NoWait to allow helm to apply manifests and keep going (needed to address data injection race condition) Adds final data injection pod wait loop after data transfer Changes from kubectl cp exec to kubectl exec Adds a dynamic sync completion marker so that data injections leveraging an initContainer don't stall on their second run Removes the arbitrary timeout conditions breaking large data syncs on slow networks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some race conditions present with data injection since the addition of the Multi-distro support in #153. This also addresses some test flakes experienced for the data injection test.
compressflag for data injections to enable gzip compression on transferNoWaitto allow helm to apply manifests and keep going (needed to address data injection race condition)kubectl cpexec tokubectl execRelated Issue
Issue #643